Adds support for v1 compatible binary names in the bundler #1
Conversation
This allows for updating at tauri v1 to v2 via the updater
|
Hi @lucasfernog, I wanted to check with you, is this change something that we would be able to upstream in Tauri (when ready) or are there some other plans? |
|
absolutely, I asked Amr to take a look at this specific issue next week |
|
Okay just as an FYI, I have put development of this PR on hold because I have realized I don't have a good way of testing the Linux bundles myself |
|
Hey, since this issue is affecting our desktop app in production, I went ahead and finished it using yours as a base :) Here is the PR: |
Thank you for picking this up, @Geometrically <3 |
|
@amrbashir thanks a lot for all of the work! @krlvi I've got a PR open bumping to |
🚧
Work in progressabandoned 🚧👉 This task was picked up in tauri-apps#10938
This allows users of a Tauri v1 application to be able to smoothly update to a Tauri v2 application via the updater.
Background:
This change in Tauri https://github.com/tauri-apps/tauri/pull/9375/files, which is noted as a refactor is in fact a breaking change as far as the app updater is concerned.
The impact is that because the binary now has a different name, it is not possible to smoothly update a Tauri application via the updater if the initial version of the app is using
v1.xand the new version is usingv2.x.Related upstream issues
tauri-apps#10548
tauri-apps/tauri-docs#2523 (docs)
Approach:
I'm introducing here an option for the
tauri-cli(tauri-bundler) for producing the same binary names it did inv1, allowing users to update the app via the updater. In order to enable this behavior, set the environment variblePreviously, the bundler did the rename just after building the binary. I poked and tried doing the same once again, but because quite a lot of the code in that bundler changed since that was merged, it felt possibly more error prone (since now the rest of the code can safely assume that the binary is the crate name)
So, instead, my approach is to do the rename the binary at the last moment (i.e. in the
bundle_projectfunction in eg. app.rs)Steps: